Repository navigation
deps: upgrade pnpm from 11 to 12.9.1 - #28
Merged
Merged
Conversation
Bump packageManager to pnpm@12.9.1 and pnpm/action-setup to v6.1.0 (first release supporting pnpm 12's native-binary package). Drop the publish workflow's 'version: 11' input, which conflicted with packageManager and made action-setup abort.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
daniel-freiermuth
marked this pull request as ready for review
October 12, 2026 06:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deps: upgrade pnpm from 11 to 12.9.1
What improved
package.jsonpackageManager:pnpm@11.3.0→pnpm@12.9.1(currentlatest, pernpm view pnpm dist-tags).pnpm/action-setup:@v4→@v6.1.0inci.yml,pages.yml,publish.yml.publish.yml: removedwith: version: 11, so the version now comes frompackageManager, the same wayci.ymlandpages.ymlalready work.pnpm-lock.yaml: pnpm 12 added its env-lockfile document at the top (packageManagerDependencies: pnpm 12.9.1plus the@pnpm/exe.*integrity hashes). The project dependency section did not change, and a secondpnpm installmade no further changes ("Already up to date").Why
pnpm/action-setup@v4,readTarget()(src/install-pnpm/run.ts) throwsMultiple versions of pnpm specifiedwhenever theversioninput is not equal to thepackageManagerversion."11"is not equal to"11.3.0", so anyv*tag push would have failed at the setup step. Takingversion:out of the workflow fixes this and leavespackage.jsonas the only place the version is set.bin.pnpmentry is an ELF binary, filled in byinstall.jsfrom@pnpm/exe.<platform>. The v4 action runs the bin through Node. Locally, pnpm 11.3.0 hit the same issue when it tried to switch to 12.9.1 (SyntaxError: Invalid or unexpected tokenon the ELF header). Support was added in action-setup v6.1.0 ("feat: support pnpm v12", feat: support pnpm v12 pnpm/action-setup#288). v5.0.0 only moved the action to Node 24, and v6.0.0 only added pnpm 11 support, so neither has breaking changes for these workflows.@v6.1.0, not the floating@v6.git ls-remoteshowsv6^{}=0977fd9, which is one commit behindv6.1.0^{}=ea17c68(the pnpm 12 support commit). So@v6would not yet install pnpm 12.pnpm 12 breaking changes checked against this repo (v12.0.0 release notes)
pnpm-workspace.yamlsettings now cause an error.pnpm-workspace.yamlonly usespackagesandallowBuilds. Install under 12.9.1 printed no unrecognized-setting warning or error.--frozen-lockfile falsewas removed. No workflow or script uses it.Verification (local, Node v24.21.0, pnpm 12.9.1 installed with
npm i -g --prefix /tmp/pnpm12 pnpm@12.9.1)pnpm install --frozen-lockfile: "Lockfile is up to date, resolution step is skipped". 187 packages,Done … using pnpm v12.9.1.pnpm check:all(the CI job: windy-lib build, wasm build, tsc, svelte-check, eslint, tests, prettier check, clippy/fmt/cargo test, webapp build): passed all the way to the finalvite build(✓ built).pnpm buildexited 0.pnpm testgave 59 pass, 0 fail.pnpm publish --dry-run --no-git-checks --access publicranprepublishOnly(tsc) and printed "Skip publishing winga-weather-routing@0.1.0 (dry run)".pnpm/action-setup@v6.1.0.Deliberately not changed
actions/checkout@v4,actions/setup-node@v4,jetli/wasm-pack-action@v0.4.0,actions/configure-pages@v5,actions/upload-pages-artifact@v3,actions/deploy-pages@v4. They are outside this finding.pnpm/action-setupis pinned to the exactv6.1.0tag. Once upstream moves the floatingv6tag to includeea17c68(or later), it can go back to@v6to pick up patch releases.packageManager: pnpm 11.3.0 fails trying to run the native binary as JS. They need to install pnpm 12 directly (for examplenpm i -g pnpm@12).DEVELOPMENT.mdonly says "pnpm" under prerequisites and was left unchanged.MODULE_TYPELESS_PACKAGE_JSONwarning forwebapp/svelte.config.jsand the >500 kB chunk warning duringvite buildexisted before this change and are unrelated to pnpm.